Great question. One that I think about often actually. For the most part we use the critical speed calculator found here
https://spicerparts.com/calculators/critical-speed-rpm-calculator However, several months ago a trainer from Spicer was here giving us a presentation, among the things he talked about was critical speed. I asked him about how different materials affect critical speed and he did not know the answer. The critical speed calculator on their website does not specify. I do know however that Spicer only uses CREW tubing. We only use DOM tubing. I don’t know if that affects the results of the critical speed or not but I would assume that it has some effect, as would the material and grade of steel. I think that there are too many variables to say that the critical speed is always X without knowing and calculating all the other factors. Also, you are going to find a lot of conflicting information such as this
https://pstds.com/critical-speed-chart and this
http://www.wallaceracing.com/driveshaftspeed.php. The calculator on the Wallace Racing website has more robust options for data input which makes me think more thought and consideration has gone into it.
However, even according to Spicer's critical speed calculator the stock front shaft on a TJ is good for about 4,300 rpm. Even with 35" tires and 5.38 gears you'd need to go about 85 mph before you hit the critical speed of the front shaft. Upgrade to an aftermarket shaft with 2" .120" wall tube and you get closer to 100 mph before hitting critical speed. In a stock shaft I think the probably loose parts and the low standard factory balance is more likely to cause problems at those speeds than the critical speed is.
For the most part though, I use Spicer's critical speed calculator as a guideline but admittedly am not afraid to push the limits at times when necessary. After all, Spicer also recommends that a universal joint's maximum operating angle at 3,000 rpm is 5.8 degrees. That's a rule that gets broken in virtually every lifted vehicle.